Use WebSockets pkg version supported on unix and enable tests #1396
Conversation
|
@dotnet-bot test outerloop Ubuntu14.01 |
1 similar comment
|
@dotnet-bot test outerloop Ubuntu14.01 |
|
@dotnet-bot test all outerloop |
|
LGTM |
| @@ -18,6 +18,7 @@ | |||
| "Microsoft.DotNet.BuildTools.TestSuite": "1.0.0-prerelease-00520-02", | |||
| "System.Collections.NonGeneric": "4.0.1", | |||
| "System.Collections.Specialized": "4.0.1", | |||
| "System.Net.WebSockets.Client": "4.0.1-beta-24322-03", | |||
There was a problem hiding this comment.
Can we try to not add "System.Net.WebSockets.Client": "4.0.1-beta-24322-03" in test-runtime as this will add this package dependency to ALL test project while we likely only need this for websocket tests?
There was a problem hiding this comment.
Chicken and egg with nuget package dependencies. Once we release a new build of the SM packages, this will get pulled in as a product dependency on all the tests anyway.
There was a problem hiding this comment.
Agreed to merge this first.
@mconnew do you like to have an issue opened to track to remove this dependency from test-runtime later or will you just remember it? 😄
Fixes #625
Fixes #420